From 799c4d622e84e15576444d1ccebed06d3be0cb8a Mon Sep 17 00:00:00 2001 From: Louis Seubert Date: Sat, 9 May 2026 22:50:22 +0200 Subject: [PATCH 1/4] chore: fix warning as error working --- Directory.Build.props | 2 +- src/process/CommandTask.cs | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/Directory.Build.props b/Directory.Build.props index 3f87bff..0a0e05e 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -16,7 +16,7 @@ Recommended true nullable - true + true diff --git a/src/process/CommandTask.cs b/src/process/CommandTask.cs index 4e1887f..186023a 100644 --- a/src/process/CommandTask.cs +++ b/src/process/CommandTask.cs @@ -19,6 +19,14 @@ public partial class CommandTask : IDisposable ProcessId = processId; } + /// + /// Finalizer to ensure resources are released. + /// + ~CommandTask() + { + Dispose(); + } + /// /// Underlying task. /// @@ -79,6 +87,7 @@ public partial class CommandTask : IDisposable public void Dispose() { Task.Dispose(); + GC.SuppressFinalize(this); } } From eaaa7abc77233e6b97c34e93c7a69bc8d02f75ba Mon Sep 17 00:00:00 2001 From: Louis Seubert Date: Sat, 9 May 2026 22:57:40 +0200 Subject: [PATCH 2/4] chore: disable code format rules in test projects --- src/process.dummy.app/.editorconfig | 6 ++++++ src/process.tests/.editorconfig | 6 ++++++ 2 files changed, 12 insertions(+) create mode 100644 src/process.dummy.app/.editorconfig create mode 100644 src/process.tests/.editorconfig diff --git a/src/process.dummy.app/.editorconfig b/src/process.dummy.app/.editorconfig new file mode 100644 index 0000000..18e8eb3 --- /dev/null +++ b/src/process.dummy.app/.editorconfig @@ -0,0 +1,6 @@ + +[*.{cs,vb}] +# disable IDE0060: Remove unused parameter +dotnet_diagnostic.IDE0060.severity = none +# disable IDE0005: Unnecessary using directive +dotnet_diagnostic.IDE0005.severity = none diff --git a/src/process.tests/.editorconfig b/src/process.tests/.editorconfig new file mode 100644 index 0000000..18e8eb3 --- /dev/null +++ b/src/process.tests/.editorconfig @@ -0,0 +1,6 @@ + +[*.{cs,vb}] +# disable IDE0060: Remove unused parameter +dotnet_diagnostic.IDE0060.severity = none +# disable IDE0005: Unnecessary using directive +dotnet_diagnostic.IDE0005.severity = none From 5a4b6f2cbbdf25d21a1d7831c1d9158575c6657a Mon Sep 17 00:00:00 2001 From: Louis Seubert Date: Sat, 9 May 2026 22:50:22 +0200 Subject: [PATCH 3/4] chore: fix warning as error working --- Directory.Build.props | 2 +- src/process/CommandTask.cs | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Directory.Build.props b/Directory.Build.props index 3f87bff..0a0e05e 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -16,7 +16,7 @@ Recommended true nullable - true + true diff --git a/src/process/CommandTask.cs b/src/process/CommandTask.cs index 4e1887f..a6c3f5c 100644 --- a/src/process/CommandTask.cs +++ b/src/process/CommandTask.cs @@ -8,7 +8,7 @@ namespace Geekeey.Process; /// /// Represents an asynchronous execution of a command. /// -public partial class CommandTask : IDisposable +public sealed partial class CommandTask : IDisposable { private readonly Process _process; @@ -82,7 +82,7 @@ public partial class CommandTask : IDisposable } } -public partial class CommandTask +public sealed partial class CommandTask { /// /// Converts the command task into a regular task. @@ -91,4 +91,4 @@ public partial class CommandTask { return commandTask.Task; } -} \ No newline at end of file +} From 20ffee6d436caa2803e34268b95d50a5027cc50b Mon Sep 17 00:00:00 2001 From: Louis Seubert Date: Sat, 9 May 2026 22:57:40 +0200 Subject: [PATCH 4/4] chore: disable code format rules in test projects --- src/process.dummy.app/.editorconfig | 6 ++++++ src/process.tests/.editorconfig | 6 ++++++ 2 files changed, 12 insertions(+) create mode 100644 src/process.dummy.app/.editorconfig create mode 100644 src/process.tests/.editorconfig diff --git a/src/process.dummy.app/.editorconfig b/src/process.dummy.app/.editorconfig new file mode 100644 index 0000000..18e8eb3 --- /dev/null +++ b/src/process.dummy.app/.editorconfig @@ -0,0 +1,6 @@ + +[*.{cs,vb}] +# disable IDE0060: Remove unused parameter +dotnet_diagnostic.IDE0060.severity = none +# disable IDE0005: Unnecessary using directive +dotnet_diagnostic.IDE0005.severity = none diff --git a/src/process.tests/.editorconfig b/src/process.tests/.editorconfig new file mode 100644 index 0000000..18e8eb3 --- /dev/null +++ b/src/process.tests/.editorconfig @@ -0,0 +1,6 @@ + +[*.{cs,vb}] +# disable IDE0060: Remove unused parameter +dotnet_diagnostic.IDE0060.severity = none +# disable IDE0005: Unnecessary using directive +dotnet_diagnostic.IDE0005.severity = none