From 54946c20fb2a96111462c74981db6c912b0ad4f7 Mon Sep 17 00:00:00 2001
From: Louis Seubert <louis.seubert.ls@gmail.com>
Date: Tue, 20 Oct 2026 21:17:15 +0200
Subject: [PATCH] fix(sdk): guard Microsoft SDK imports

---
 src/sdk.tests/fixtures/razor/RazorConsumer.csproj    | 8 ++++++++
 src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Razor/Sdk.props   | 6 +++---
 src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Razor/Sdk.targets | 2 +-
 src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Test/Sdk.props    | 6 +++---
 src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Test/Sdk.targets  | 2 +-
 src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Web/Sdk.props     | 6 +++---
 src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Web/Sdk.targets   | 2 +-
 src/sdk/Sdk/Geekeey.Arcade.NET.Sdk/Sdk.props         | 6 +++---
 src/sdk/Sdk/Geekeey.Arcade.NET.Sdk/Sdk.targets       | 2 +-
 9 files changed, 24 insertions(+), 16 deletions(-)
 create mode 100644 src/sdk.tests/fixtures/razor/RazorConsumer.csproj

diff --git a/src/sdk.tests/fixtures/razor/RazorConsumer.csproj b/src/sdk.tests/fixtures/razor/RazorConsumer.csproj
new file mode 100644
index 0000000..b3de58d
--- /dev/null
+++ b/src/sdk.tests/fixtures/razor/RazorConsumer.csproj
@@ -0,0 +1,8 @@
+<Project Sdk="Geekeey.Arcade.NET.Sdk.Razor/{0}">
+	<PropertyGroup>
+		<TargetFramework>net10.0</TargetFramework>
+		<PackageId>RazorConsumer</PackageId>
+		<StaticWebAssetsEnabled>false</StaticWebAssetsEnabled>
+		<NoWarn>IDE0055</NoWarn>
+	</PropertyGroup>
+</Project>
diff --git a/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Razor/Sdk.props b/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Razor/Sdk.props
index 8252210..72503c0 100644
--- a/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Razor/Sdk.props
+++ b/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Razor/Sdk.props
@@ -1,13 +1,13 @@
 <Project>
 	<PropertyGroup>
-		<UsingMicrosoftNETSdk Condition="'$(UsingMicrosoftNETSdk)' == ''">true</UsingMicrosoftNETSdk>
+		<_MustImportMicrosoftNETSdk Condition="'$(UsingMicrosoftNETSdk)' != 'true'">true</_MustImportMicrosoftNETSdk>
 
 		<CustomBeforeDirectoryBuildProps>$(CustomBeforeDirectoryBuildProps);$(MSBuildThisFileDirectory)../common/Common.props</CustomBeforeDirectoryBuildProps>
 		<BeforeMicrosoftNETSdkTargets>$(BeforeMicrosoftNETSdkTargets);$(MSBuildThisFileDirectory)/../common/Common.targets</BeforeMicrosoftNETSdkTargets>
 	</PropertyGroup>
 
-	<Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk.Razor" Condition="'$(UsingMicrosoftNETSdk)' == 'true'" />
-	<Import Project="$(MSBuildThisFileDirectory)../common/Common.props" Condition="'$(UsingMicrosoftNETSdk)' != 'true'" />
+	<Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk.Razor" Condition="'$(_MustImportMicrosoftNETSdk)' == 'true'" />
+	<Import Project="$(MSBuildThisFileDirectory)../common/Common.props" Condition="'$(_MustImportMicrosoftNETSdk)' != 'true'" />
 
 	<ItemGroup>
 		<EditorConfigFiles Include="$(MSBuildThisFileDirectory)../configuration/Geekeey.Arcade.NET.Sdk.Razor.editorconfig" />
diff --git a/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Razor/Sdk.targets b/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Razor/Sdk.targets
index 49c75ac..169fe69 100644
--- a/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Razor/Sdk.targets
+++ b/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Razor/Sdk.targets
@@ -1,3 +1,3 @@
 <Project>
-	<Import Project="Sdk.targets" Sdk="Microsoft.NET.Sdk.Razor" Condition="'$(UsingMicrosoftNETSdk)' == 'true'" />
+	<Import Project="Sdk.targets" Sdk="Microsoft.NET.Sdk.Razor" Condition="'$(_MustImportMicrosoftNETSdk)' == 'true'" />
 </Project>
diff --git a/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Test/Sdk.props b/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Test/Sdk.props
index 2e198cf..6683f9f 100644
--- a/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Test/Sdk.props
+++ b/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Test/Sdk.props
@@ -1,13 +1,13 @@
 <Project>
 	<PropertyGroup>
-		<UsingMicrosoftNETSdk Condition="'$(UsingMicrosoftNETSdk)' == ''">true</UsingMicrosoftNETSdk>
+		<_MustImportMicrosoftNETSdk Condition="'$(UsingMicrosoftNETSdk)' != 'true'">true</_MustImportMicrosoftNETSdk>
 
 		<CustomBeforeDirectoryBuildProps>$(CustomBeforeDirectoryBuildProps);$(MSBuildThisFileDirectory)../common/Common.props</CustomBeforeDirectoryBuildProps>
 		<BeforeMicrosoftNETSdkTargets>$(BeforeMicrosoftNETSdkTargets);$(MSBuildThisFileDirectory)/../common/Common.targets</BeforeMicrosoftNETSdkTargets>
 	</PropertyGroup>
 
-	<Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk" Condition="'$(UsingMicrosoftNETSdk)' == 'true'" />
-	<Import Project="$(MSBuildThisFileDirectory)../common/Common.props" Condition="'$(UsingMicrosoftNETSdk)' != 'true'" />
+	<Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk" Condition="'$(_MustImportMicrosoftNETSdk)' == 'true'" />
+	<Import Project="$(MSBuildThisFileDirectory)../common/Common.props" Condition="'$(_MustImportMicrosoftNETSdk)' != 'true'" />
 
 	<ItemGroup>
 		<EditorConfigFiles Include="$(MSBuildThisFileDirectory)../configuration/Geekeey.Arcade.NET.Sdk.Test.editorconfig" />
diff --git a/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Test/Sdk.targets b/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Test/Sdk.targets
index acc1558..c34d867 100644
--- a/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Test/Sdk.targets
+++ b/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Test/Sdk.targets
@@ -1,3 +1,3 @@
 <Project>
-	<Import Project="Sdk.targets" Sdk="Microsoft.NET.Sdk" Condition="'$(UsingMicrosoftNETSdk)' == 'true'" />
+	<Import Project="Sdk.targets" Sdk="Microsoft.NET.Sdk" Condition="'$(_MustImportMicrosoftNETSdk)' == 'true'" />
 </Project>
diff --git a/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Web/Sdk.props b/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Web/Sdk.props
index af3d0a9..1666365 100644
--- a/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Web/Sdk.props
+++ b/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Web/Sdk.props
@@ -1,13 +1,13 @@
 <Project>
 	<PropertyGroup>
-		<UsingMicrosoftNETSdk Condition="'$(UsingMicrosoftNETSdk)' == ''">true</UsingMicrosoftNETSdk>
+		<_MustImportMicrosoftNETSdk Condition="'$(UsingMicrosoftNETSdk)' != 'true'">true</_MustImportMicrosoftNETSdk>
 
 		<CustomBeforeDirectoryBuildProps>$(CustomBeforeDirectoryBuildProps);$(MSBuildThisFileDirectory)../common/Common.props</CustomBeforeDirectoryBuildProps>
 		<BeforeMicrosoftNETSdkTargets>$(BeforeMicrosoftNETSdkTargets);$(MSBuildThisFileDirectory)/../common/Common.targets</BeforeMicrosoftNETSdkTargets>
 	</PropertyGroup>
 
-	<Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk.Web" Condition="'$(UsingMicrosoftNETSdk)' == 'true'" />
-	<Import Project="$(MSBuildThisFileDirectory)../common/Common.props" Condition="'$(UsingMicrosoftNETSdk)' != 'true'" />
+	<Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk.Web" Condition="'$(_MustImportMicrosoftNETSdk)' == 'true'" />
+	<Import Project="$(MSBuildThisFileDirectory)../common/Common.props" Condition="'$(_MustImportMicrosoftNETSdk)' != 'true'" />
 
 	<ItemGroup>
 		<EditorConfigFiles Include="$(MSBuildThisFileDirectory)../configuration/Geekeey.Arcade.NET.Sdk.Web.editorconfig" />
diff --git a/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Web/Sdk.targets b/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Web/Sdk.targets
index 8bb4915..2f7da47 100644
--- a/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Web/Sdk.targets
+++ b/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk.Web/Sdk.targets
@@ -1,3 +1,3 @@
 <Project>
-	<Import Project="Sdk.targets" Sdk="Microsoft.NET.Sdk.Web" Condition="'$(UsingMicrosoftNETSdk)' == 'true'" />
+	<Import Project="Sdk.targets" Sdk="Microsoft.NET.Sdk.Web" Condition="'$(_MustImportMicrosoftNETSdk)' == 'true'" />
 </Project>
diff --git a/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk/Sdk.props b/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk/Sdk.props
index f42b153..9937919 100644
--- a/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk/Sdk.props
+++ b/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk/Sdk.props
@@ -1,13 +1,13 @@
 <Project>
 	<PropertyGroup>
-		<UsingMicrosoftNETSdk Condition="'$(UsingMicrosoftNETSdk)' == ''">true</UsingMicrosoftNETSdk>
+		<_MustImportMicrosoftNETSdk Condition="'$(UsingMicrosoftNETSdk)' != 'true'">true</_MustImportMicrosoftNETSdk>
 
 		<CustomBeforeDirectoryBuildProps>$(CustomBeforeDirectoryBuildProps);$(MSBuildThisFileDirectory)../common/Common.props</CustomBeforeDirectoryBuildProps>
 		<BeforeMicrosoftNETSdkTargets>$(BeforeMicrosoftNETSdkTargets);$(MSBuildThisFileDirectory)/../common/Common.targets</BeforeMicrosoftNETSdkTargets>
 	</PropertyGroup>
 
-	<Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk" Condition="'$(UsingMicrosoftNETSdk)' == 'true'" />
-	<Import Project="$(MSBuildThisFileDirectory)../common/Common.props" Condition="'$(UsingMicrosoftNETSdk)' != 'true'" />
+	<Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk" Condition="'$(_MustImportMicrosoftNETSdk)' == 'true'" />
+	<Import Project="$(MSBuildThisFileDirectory)../common/Common.props" Condition="'$(_MustImportMicrosoftNETSdk)' != 'true'" />
 
 	<ItemGroup>
 		<EditorConfigFiles Include="$(MSBuildThisFileDirectory)../configuration/Geekeey.Arcade.NET.Sdk.editorconfig" />
diff --git a/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk/Sdk.targets b/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk/Sdk.targets
index acc1558..c34d867 100644
--- a/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk/Sdk.targets
+++ b/src/sdk/Sdk/Geekeey.Arcade.NET.Sdk/Sdk.targets
@@ -1,3 +1,3 @@
 <Project>
-	<Import Project="Sdk.targets" Sdk="Microsoft.NET.Sdk" Condition="'$(UsingMicrosoftNETSdk)' == 'true'" />
+	<Import Project="Sdk.targets" Sdk="Microsoft.NET.Sdk" Condition="'$(_MustImportMicrosoftNETSdk)' == 'true'" />
 </Project>